Skip to content

Commit

Permalink
tests/riotboot: avoid compilation during test
Browse files Browse the repository at this point in the history
- Use .bin instead of .elf since those are the actual files
  use for testing.
  • Loading branch information
fjmolinas committed Oct 15, 2019
1 parent 9bc600a commit 0fbd170
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
5 changes: 0 additions & 5 deletions makefiles/boot/riotboot.mk
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ $(BINDIR_APP)-slot1.elf: FW_ROM_LEN=$$((SLOT1_LEN - $(RIOTBOOT_HDR_LEN)))
$(BINDIR_APP)-slot1.elf: ROM_OFFSET=$(SLOT1_IMAGE_OFFSET)
SLOT_RIOT_ELFS = $(BINDIR_APP)-slot0.elf $(BINDIR_APP)-slot1.elf

# ensure both slot elf files are always linked
# this ensures that both "make test" and "make test-murdock" can rely on them
# being present without having to trigger re-compilation.
BUILD_FILES += $(SLOT_RIOT_ELFS)

# Create binary target with RIOT header
$(SLOT_RIOT_BINS): %.$(APP_VER).riot.bin: %.hdr %.bin
@echo "creating $@..."
Expand Down
12 changes: 11 additions & 1 deletion tests/riotboot/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,21 @@ QUIET ?= 1
# Thus default to that (instead of epoch set by makefiles/boot/riotboot.inc.mk).
APP_VER?=0

# To avoid compilation during the test ensure both slot bin files are always
# generated and linked this ensures that "BUILD_IN_DOCKER=1 make test"
# can rely on them being present without having to trigger re-compilation.
BUILD_FILES += $(SLOT_RIOT_BINS)

# To avoid compilation during the test ensure both slot elf files are always
# generated and linked this ensures that "make test-murdock"
# can rely on them being present without having to trigger re-compilation.
BUILD_FILES += $(SLOT_RIOT_ELFS)

# The test needs the linked slot binaries without header in order to be able to
# create final binaries with specific APP_VER values. The CI RasPi test workers
# don't compile themselves, thus add the required files here so they will be
# submitted along with the test jobs.
TEST_EXTRA_FILES=$(SLOT_RIOT_ELFS)
TEST_EXTRA_FILES += $(SLOT_RIOT_ELFS)

include ../Makefile.tests_common
include $(RIOTBASE)/Makefile.include

0 comments on commit 0fbd170

Please sign in to comment.