Skip to content

Commit

Permalink
pkg/nimble: Replace double quotes with single quotes for two CFLAGS
Browse files Browse the repository at this point in the history
Using double quotes can cause issue when the final cmake command is called, and you end up with un-escpaed nested double quotes.
  • Loading branch information
blueted2 authored Jul 27, 2022
1 parent 7ee1b58 commit 25a476f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/nimble/Makefile.include
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ ifneq (,$(filter nimble_netif,$(USEMODULE)))

# in order to fit a 251 byte COC data segment into a single mbuf buffer, the
# used block size must be at least 297 byte (251 data + 48 overhead)
CFLAGS += -DMYNEWT_VAL_MSYS_1_BLOCK_SIZE="(MYNEWT_VAL_BLE_L2CAP_COC_MPS + 48)"
CFLAGS += -DMYNEWT_VAL_MSYS_1_BLOCK_SIZE='(MYNEWT_VAL_BLE_L2CAP_COC_MPS + 48)'

# in the worst case, NimBLEs internal buffer needs to hold two full IPv6 MTUs
# per connection (1 TX and 1 RX). But in practice this would be highly over-
Expand All @@ -156,7 +156,7 @@ else

# in order to fit a 251 byte COC data segment into a single mbuf buffer, the
# used block size must be at least 297 byte (251 data + 48 overhead)
CFLAGS += -DMYNEWT_VAL_MSYS_1_BLOCK_SIZE="(MYNEWT_VAL_BLE_L2CAP_COC_MPS + 48)"
CFLAGS += -DMYNEWT_VAL_MSYS_1_BLOCK_SIZE='(MYNEWT_VAL_BLE_L2CAP_COC_MPS + 48)'
endif
endif

Expand Down

0 comments on commit 25a476f

Please sign in to comment.