Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/gcoap: evaluate gcoap thread stack size #12817

Closed
kb2ma opened this issue Nov 26, 2019 · 2 comments
Closed

net/gcoap: evaluate gcoap thread stack size #12817

kb2ma opened this issue Nov 26, 2019 · 2 comments
Labels
Area: CoAP Area: Constrained Application Protocol implementations State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Comments

@kb2ma
Copy link
Member

kb2ma commented Nov 26, 2019

Description

In #8998 we increased the stack size of the gcoap thread by sizeof(coap_pkt_t) due to overflow reported in #8981. Now that #12774 has been merged, we have reduced the use of the stack by 128 bytes by default. Does it make sense to reduce the stack size of the gcoap thread now?
@kb2ma kb2ma added Area: CoAP Area: Constrained Application Protocol implementations Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Nov 26, 2019
@kb2ma
Copy link
Member Author

kb2ma commented Nov 26, 2019

@haukepetersen, does the work that triggered #12774 provide any guidance?

@stale
Copy link

stale bot commented May 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label May 30, 2020
@kb2ma kb2ma closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations State: stale State: The issue / PR has no activity for >185 days Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kb2ma