Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/gcoap: increase stack size by sizeof(coap_pkt_t) #8998

Merged
merged 1 commit into from
Apr 23, 2018
Merged

net/gcoap: increase stack size by sizeof(coap_pkt_t) #8998

merged 1 commit into from
Apr 23, 2018

Conversation

kaspar030
Copy link
Contributor

Contribution description

Apparently the latest nanocoap rework had side effects on gcoap's stack usage, and not of the good kind.

This PR adds sizeof(coap_pkt_t) to the gcoap stacksize. Meant as quickfix for the release, better solution is on its way.

Issues/PRs references

Fixes #8981.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch labels Apr 22, 2018
@kaspar030 kaspar030 requested a review from miri64 April 22, 2018 21:19
@kaspar030
Copy link
Contributor Author

@miri64 could you quickly check that this fixes your problem?

@kb2ma kb2ma self-requested a review April 23, 2018 04:38
kb2ma
kb2ma approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@kb2ma kb2ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update worked for me on samr21-xpro. Available stack size increased from 1024 to 1240. Used stack initially was 788, and increased to 1116 after sending a message.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Apr 23, 2018
@kaspar030 kaspar030 merged commit b4d2882 into RIOT-OS:master Apr 23, 2018
@kaspar030 kaspar030 deleted the gcoap_increase_stacksize branch April 23, 2018 07:43
@kaspar030 kaspar030 mentioned this pull request Apr 23, 2018
Merged
@kb2ma kb2ma mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kb2ma kb2ma kb2ma approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2018.04
Development

Successfully merging this pull request may close these issues.

examples: gcoap: stack overflow when NON times out
3 participants
@kaspar030 @kb2ma @cladmi