Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/xtimer_hang: use xtimer_periodic_wakeup #10396

Merged
merged 1 commit into from
Dec 21, 2018
Merged

test/xtimer_hang: use xtimer_periodic_wakeup #10396

merged 1 commit into from
Dec 21, 2018

Conversation

Josar
Copy link
Contributor

@Josar Josar commented Nov 15, 2018

When sleeping in the main function with xtimer_sleep not every percentage
will be printed as the sleep duration and the processing time added do not result in full percentage values.

Using xtimer_periodic_wakeup ensures that every integer percentage is printed.

This requires xtimer_periodic_wakeup to work properly. see #10393

@Josar
test/xtimer_hang: use xtimer_periodic_wakeup
82d1261 
When sleeping in the main function with xtimer_sleep not every percentage
will be printed as the sleep duration and the processing time added do
not result in full percentage values.

Using xtimer_periodic_wakeup ensures that every integer percentage is printed.
@A-Paul A-Paul added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework State: waiting for other PR State: The PR requires another PR to be merged first Area: timers Area: timer subsystems Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Nov 16, 2018
@Josar Josar mentioned this pull request Dec 18, 2018
Closed
@smlng smlng added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Dec 21, 2018
smlng
smlng approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@smlng smlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK!

@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 21, 2018
@smlng
Copy link
Member

smlng commented Dec 21, 2018

I don't think this strictly requires #10393, removing label and re-run CI

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Dec 21, 2018
@smlng smlng merged commit cf1a5e0 into RIOT-OS:master Dec 21, 2018
@aabadie aabadie added this to the Release 2019.01 milestone Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlng smlng smlng approved these changes

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework Area: timers Area: timer subsystems CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
4 participants
@Josar @smlng @aabadie @A-Paul