gnrc_ipv6_nib: use correct reverse-translate for ARSM-less NCE #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: bug
miri64
removed
the
State: waiting for other PR
miri64
force-pushed
the
gnrc_ipv6_nib/bug/correct-reverse
branch
from
791ecf1 to
fa5f332
Compare
|
Rebased to current master. No longer waiting on another PR. |
TimoRoth
reviewed
Dec 11, 2018
miri64
added
the
CI: ready for build
|
@miri64 please squash |
The current implementation uses the assumption that the IPv6 address is always based on an EUI-64, which it doesn't has to.
miri64
force-pushed
the
gnrc_ipv6_nib/bug/correct-reverse
branch
from
c263167 to
f160849
Compare
|
Squashed |
|
@miri64 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The current implementation uses the assumption that the IPv6 address is always based on an EUI-64, which it doesn't has to.
Testing procedure
tests/gnrc_ipv6_nib,tests/gnrc_ipv6_nib_6ln, andtests/unittestsshould still pass, adding and viewing link-local neighbor cache entries on a non-routing 6Lo host (e.g.examples/gcoap) should still work.Issues/PRs references
Depends on
#10513(merged).