boards/nz32-sc151: do not blindly set TERMFLAGS #11065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The board should not globally set `TERMFLAGS` without a RIOT_TERMINAL condition. Also the board does not export uart through usb and thus needs an uart converter connected. Other boards in the same situation do not need to set `TERMPROG` without a valid baudrate. So remove the definition anyway. This also removes the export of TERM* variables and should make it work with the other RIOT_TERMINAL.
cladmi
added
Type: bug
19 tasks
aabadie
approved these changes
Mar 5, 2019
aabadie
added
the
CI: ready for build
|
Thank you for the review. |
|
Youhou no more 'export TERMPROG' or 'export TERMFLAGS'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The board should not globally set
TERMFLAGSwithout a RIOT_TERMINALcondition.
Also the board does not export uart through usb and thus needs an uart
converter connected. Other boards in the same situation do not need
to set
TERMPROGwithout a valid baudrate. So remove the definitionanyway.
This also removes the export of TERM* variables and should make it work
with the other RIOT_TERMINAL.
RIOT/boards/nz32-sc151/doc.txt
Lines 56 to 61 in 7e0891e
Testing procedure
I do not have the board here but testing the board with an external uart should still work.
@aabadie
Also you can review the commit message if it makes sense for the board or not.
Issues/PRs references
Tracking issue: #10850
Found while working on #10952