Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32_common: remove WKUP2 pin enable #11167

Merged
merged 1 commit into from
Mar 12, 2019
Merged

cpu/stm32_common: remove WKUP2 pin enable #11167

merged 1 commit into from
Mar 12, 2019

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Mar 12, 2019 •
edited
Loading

Contribution description

Currently StandBy mode is unusable for nucleo l0 boards. When looking at the datasheet:

WKUP pin 2 is used for wakeup from Standby mode and forced in input pull down
configuration (rising edge on WKUP pin 2 wakes-up the system from Standby mode).

But when looking at the boards schematic PC13 (wake-up pin 2), is also the user button which is connected to VDD, this means that unless user is holding the user button pressed all the time, a rising edge is triggered immediately. More so, it leaves the MCU in a weird state after reset.

Not enabling wake up pin 2 when entering StandBy fixes the issue.

Testing procedure

On nucleo boards that support LPM run:

make BOARD=nucleo-l073rz -C tests/periph_pm/ PORT=/dev/ttyACM0 clean flash
unblock 0
unblock 1
unblock_rtc 1 3

Issues/PRs references

@aabadie aabadie self-requested a review March 12, 2019 15:36
@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: pm Area: (Low) power management Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 12, 2019
aabadie
aabadie approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my nucleo-l073rz board, I can confirm the mentioned problem is fixed by this PR.

ACK, let's merge when CI is green

@aabadie
Copy link
Contributor

aabadie commented Mar 12, 2019

All green, let's go. Thanks @fjmolinas !

@aabadie aabadie merged commit 57e3a7c into RIOT-OS:master Mar 12, 2019
@aabadie aabadie mentioned this pull request Mar 13, 2019
Merged
@fjmolinas fjmolinas mentioned this pull request Mar 13, 2019
Merged
@danpetry danpetry added this to the Release 2019.04 milestone Mar 26, 2019
@fjmolinas fjmolinas deleted the stm32_common_wake_pin_2 branch August 7, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: pm Area: (Low) power management CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @aabadie @danpetry