pkg/semtech-loramac: provide a way to disable dutycycle #11241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duty cycle can be disabled by building the application using CFLAGS=-DDISABLE_LORAMAC_DUTYCYCLE
aabadie
added
Area: pkg
|
@aabadie Maybe some documentarion in tests/pkg_semtech_loramac? That way it isn't in the public examples but only in the tests. And is properly documented for running CI test or stuff like that. |
Good idea, I pushed e5831cf that contains this. |
|
@aabadie like it! |
|
Thanks @fjmolinas, now I just need an ACK. Maybe @jia200x ? |
|
ping @jia200x |
|
the change makes sense. I will test it now |
|
it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides an hidden way to disable the loramac duty-cycle restriction.
See problems with OTAA and STOP mode explained in #11237 for details.
I want this change to remain hidden (not in the public API) because this is only for testing purpose normally, as explained in loramac-node code. But maybe it's worth to document it somewhere ? suggestions are welcome.
Testing procedure
tests/pkg_semtech-loramacwith CFLAGS=-DDISABLE_LORAMAC_DUTYCYCLEIssues/PRs references
This PR provides a fix for OTAA + STOP deep-sleep mode that was raised in #11237