cpu/stm32: centralize PM_BLOCKER_INITIAL define #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Platform: ARM
kaspar030
reviewed
Apr 12, 2019
| * @brief Default initial PM blocker | ||
| * @todo All modes are blocked per default, until PM is cleanly implemented | ||
| */ | ||
| #define PM_BLOCKER_INITIAL { .val_u32 = 0x01010101 } |
There was a problem hiding this comment.
this is now identical as in sys/pm_layered/pm.c. Should we just drop it?
There was a problem hiding this comment.
Yes that was the alternative solution I proposed in the initial comment of this PR. If it's ok for you I can drop it no problem :)
There was a problem hiding this comment.
Ah, I just saw that. Yeah, let's drop it.
aabadie
force-pushed
the
pr/cpu/stm32l0_pm_initial_blocker
branch
from
61b9652 to
db9b341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR move the PM_BLOCKER_INITIAL macro definition of stm32f1/stm32l0 to a common stm32 place. This is because all STM32 families now support pm_layered.
The define is also overridable now: this is required when one wants to unlock by default a certain pm mode from its application Makefile (useful with LoRaWAN).
Another option is to completely remove the define from stm32l0 and stm32f1, since the default value in pm_layered is already the same. Maybe this would be the preferred solution ?
Testing procedure
A green Murdock should be enough. One can also add
CFLAGS += '-DPM_BLOCKER_INITIAL={ .val_u32=0x01010100 }'in any application and verify that it builds without error.Issues/PRs references
Required by #11237