Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefiles/docker: export BOARDS #11385

Merged
merged 1 commit into from
May 6, 2019

Conversation

kaspar030
Copy link
Contributor

Contribution description

This enables "BUILD_IN_DOCKER=1 BOARDS='foo bar' make buildtest".
Without this line, when executed with BUILD_IN_DOCKER, "make buildtest"
would always build all boards.

Testing procedure

BUILD_IN_DOCKER=1 BOARDS="samr21-xpro arduino-uno" make -Cexamples/hello-world buildtest

On master, this builds all boards. With this PR, only the two selected.

Issues/PRs references

RIOT-OS/riotdocker#72

This enables "BUILD_IN_DOCKER=1 BOARDS='foo bar' make buildtest".
Without this line, when executed with BUILD_IN_DOCKER, "make buildtest"
would always build all boards.
@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 12, 2019
@kaspar030 kaspar030 requested a review from miri64 April 12, 2019 07:27
@kaspar030 kaspar030 requested a review from cladmi May 6, 2019 11:45
@kaspar030
Copy link
Contributor Author

ping this should be a low-hanging fruit.

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed.

@miri64 miri64 merged commit c50eebe into RIOT-OS:master May 6, 2019
@kaspar030 kaspar030 deleted the docker_export_boards branch July 5, 2019 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants