Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/nimble_scanner: fix typo in scan command description #11464

Merged
merged 1 commit into from
Apr 29, 2019
Merged

examples/nimble_scanner: fix typo in scan command description #11464

merged 1 commit into from
Apr 29, 2019

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Apr 29, 2019

Contribution description

This PR is fixing an obvious typo in the examples/nimble_scanner shell command description.

Testing procedure

  • Build and flash examples/nimble_scanner on one of the supported board
  • Call help, the typo in scan command description should be gone with this PR.

Issues/PRs references

Found in #11463 while testing examples/nimble_scanner on nrf51

@aabadie aabadie added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Apr 29, 2019
@aabadie aabadie requested a review from miri64 April 29, 2019 09:44
miri64
miri64 approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 5eaf45c into RIOT-OS:master Apr 29, 2019
@aabadie aabadie deleted the pr/examples/nimble_scanner_typo branch April 29, 2019 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @miri64