-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kinetis: move filtering-out periph_hwrng in cpu/kinetis #11479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK for the proposed HACK. I would just reword a bit the comments.
cpu/kinetis/Makefile.features
Outdated
FEATURES_PROVIDED += periph_hwrng | ||
|
||
# HACK Do not define 'hwrng' if the board does not supports it | ||
# I prefer a whitelist on CPU_MODEL but the information is not available yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has too much personal taste (e.g. don't use I prefer
). Maybe reword with: A whitelist on CPU_MODEL would be better but this information/variable is not available yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, will change.
cpu/kinetis/Makefile.features
Outdated
|
||
# HACK Do not define 'hwrng' if the board does not supports it | ||
# I prefer a whitelist on CPU_MODEL but the information is not available yet | ||
# HACK the board/cpu_model currently uses the wrong hwrng register |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand this correctly, the wrong hwrng register is used for frdm-k64f ? Maybe make this more explicit that this HACK applies to frdm-kw64f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to re-precise this when moving it to the common directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While re-reading I am not sure if it is the frdm-k64f
or the CPU_MODEL
completely. That is why I wrote board/cpu_model
. I think it may be more cpu_model but hard to know without debugging why.
I can change to Hack, either the board or the cpu_model currently uses the wrong hwrng
maybe ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe start the next sentence on the same line:
HACK the board/cpu_model currently uses the wrong hwrng register. Remove next line when fixed
(you can split it if it's too long)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can just remove the "remove next line when fixed" as it is implicit and still precise the frdm
as it is currently the only one I know as you said in the first comment.
The HWRNG uses the wrong hwrng register for the frdm-k64f board/cpu_model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. ACK
Please squash
This removes doing `filter-out periph_hwrng, $(FEATURES_PROVIDED)` after processing `cpu/$(CPU)/Makefile.features`. The current solution is a HACK as `CPU_MODEL` is currently not available at that moment but will be in the near future. It will allow always including `cpu/$(CPU)/Makefile.features` after `boards/$(BOARD)/Makefile.features`. It is a part of moving `CPU/CPU_MODEL` definitions to `Makefile.features`.
Squashed. |
and go! |
Thanks :) |
Contribution description
This removes doing
filter-out periph_hwrng, $(FEATURES_PROVIDED)
after processing
cpu/$(CPU)/Makefile.features
.The current solution is a HACK as
CPU_MODEL
is currently not availableat that moment but will be in the near future.
It will allow always including
cpu/$(CPU)/Makefile.features
afterboards/$(BOARD)/Makefile.features
.It is a part of moving
CPU/CPU_MODEL
definitions toMakefile.features
.Testing procedure
For all the modified boards, the provided features are the same as in
master
.I only checked
examples/hello-world
as it should not change anything for these ones.I also looked at all boards to verify they did not change but did not post the output.
Issues/PRs references
Required to apply #11478
Split out of #11477