-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefiles/toolchain: fallback to 'objdump' #11547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK, works on macOS.
I prefer to first try plain (non arch specific) objdump
and if that is not present fail.
@cladmi if you think this is good to go, feel free to hit the green button. |
@smlng you mean failing with If objdump is not found you would get a shell error Currently you get a It should not do an |
I'd say: make it consistent with the behaviour for |
I noticed that currently for Lines 596 to 598 in 35d43cc
I will update to remove the |
and maybe also add the alternative to look for |
Did not know thought that it could exist, I will. |
I noticed something weird on my machine while testing this, if I was doing |
When I test for |
@smlng Tell me if I should squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a small oops, otherwise it is OK.
Thanks I missed that one D: |
I re-tested #11545 on top of the current changes and the testing procedure works. |
please squash, if @jcarrano agrees 😄 |
When '$(PREFIX)objdump' is not present fallback to native '(g)objdump'. 'objdump' is used when flashing for some boards but the toolchain may not be installed when building in docker. This will allow using 'objdump' in 'cpu/kinetis/dist/check-fcfield.sh'.
Squashed first and rebased. It will allow basing #11545 on top for testing. |
Thank you for the review! |
Contribution description
When '$(PREFIX)objdump' is not present fallback to 'objdump'.
'objdump' is used when flashing for some boards but the toolchain may
not be installed when building in docker.
If none is found, I fallback to saying 'false' but not sure if it is a
decent solution or not. Maybe just always default to 'objdump' ?
This will allow using 'objdump' in 'cpu/kinetis/dist/check-fcfield-elf.sh'.
Question
Should the default be
false
orobjdump
which may not be present ?Testing procedure
Removed in the last version
It also solves the main issue to use
objdump
when flashingkinetis
boards whenarm-none-eabi-ojbdump
is not present. See main PR #11545Issues/PRs references
Part of #11545 to flash kinetis without arm toolchain.
Which is part of #10870 to only use toolchain from docker.