-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: allow to override RESET and RESET_FLAGS for all boards and tools #11649
Conversation
heh piling up those commits 😆 |
that's (really) just so we can identify and revert if a certain board or tool fails 😬 |
Would be good to verify all the values are still the same with |
If you want to prevent the pattern to be re-appearing in the future, you can add a detection for it in https://github.com/cladmi/RIOT/blob/master/dist/tools/buildsystem_sanity_check/check.sh I checked the output right now.
And the output of The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed and tested that it did not change the output of RESET
and RESET_FLAGS
in the default and jlink case.
It is also a task I would like to have with |
thanks @cladmi for review and merge!! |
Contribution description
This PR adapts Makefiles to allow for overriding the RESET command (or tool) and required RESET_FLAGS (if any present). For some boards like sam0 based once this is already possible, this PR adds this for all remaining.
This is required to allow for custom or special reset commands, for instance when running hardware-in-the-loop tests in a well known (special) environment which might allow to reset a board by controlling the power via a side-channel.
Testing procedure
try to run
make reset
for you favourite board that should still work. You may also try to runRESET="" RESET_FLAGS="" make reset
which than should fail to reset the board.Issues/PRs references