Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/lobaro-lorabox: add sx1272 radio driver dependency to netdev_default #11768

Merged
merged 2 commits into from
Jul 4, 2019

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jul 1, 2019

Contribution description

This PR adds sx1272 radio driver dependency to the lobaro-lorabox when netdev-default module is loaded. This gives access to ifconfig/txtsnd with this board when using the examples/default application.

Testing procedure

  • Build and flash examples/default
  • Play with ifconfig and txtsnd to control the LoRa radio interface

Issues/PRs references

Found while working on #11676.

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: LoRa Area: LoRa radio support Area: boards Area: Board ports labels Jul 1, 2019
@aabadie aabadie requested a review from leandrolanzieri July 1, 2019 12:54
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the current way of doing it, but I would really like to see something like #11676. I tested this and works fine. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jul 4, 2019
@leandrolanzieri leandrolanzieri merged commit 5492214 into RIOT-OS:master Jul 4, 2019
@aabadie aabadie deleted the pr/boards/lobaro_lorabox branch July 4, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: LoRa Area: LoRa radio support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants