Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/libcose: bump version #11801

Merged
merged 2 commits into from
Jul 18, 2019
Merged

pkg/libcose: bump version #11801

merged 2 commits into from
Jul 18, 2019

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Jul 5, 2019 •
edited
Loading

Contribution description

This updates pkg/libcose to current master.
The API evolved a bit, thus the test needs adoption.
Also, libcose now uses nanocbor.

Marking WIP until the test works again. (tests updated)

Testing procedure

  • let CI confirm the test still works

Issues/PRs references

@kaspar030 kaspar030 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: pkg Area: External package ports labels Jul 5, 2019
@kaspar030 kaspar030 requested a review from bergzand July 5, 2019 13:19
@kaspar030 kaspar030 changed the title pkg/lobcose: bump version pkg/libcose: bump version Jul 5, 2019
@kaspar030 kaspar030 force-pushed the update_pkg_libcose branch from b3c38e7 to 1123299 Compare July 8, 2019 10:22
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 8, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
88dec2e
@kaspar030 kaspar030 mentioned this pull request Jul 8, 2019
Merged
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 10, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
efa0122
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 10, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
2e4602c
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 12, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
33845ea
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 12, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
c99f8b7
kaspar030 added a commit to kaspar030/RIOT that referenced this pull request Jul 15, 2019
@kaspar030
DEPENDENCY MERGE: update_pkg_libcose (RIOT-OS#11801)
94bbd63
@kaspar030 kaspar030 force-pushed the update_pkg_libcose branch from 1123299 to 33a0656 Compare July 17, 2019 07:25
@fjmolinas fjmolinas force-pushed the update_pkg_libcose branch from 33a0656 to 6a53058 Compare July 17, 2019 07:37
@kaspar030 kaspar030 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jul 17, 2019
@kaspar030 kaspar030 force-pushed the update_pkg_libcose branch from 303a1bc to 7df0d13 Compare July 17, 2019 08:30
@kaspar030 kaspar030 requested a review from fjmolinas July 17, 2019 08:30
@kaspar030 @fjmolinas
tests/pkg_libcose: update to nanocbor-based libcose
40c8953 
Co-authored-by: Francisco Molina <femolina@uc.cl>
@kaspar030 kaspar030 force-pushed the update_pkg_libcose branch from 7df0d13 to 84bf09c Compare July 17, 2019 08:32
@kaspar030
Copy link
Contributor Author

This is not WIP anymore. Commit history got messy, so I rebased and squashed. Ready for review!

@kaspar030 kaspar030 added CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 17, 2019
fjmolinas
fjmolinas reviewed Jul 17, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that #11818 is still working and that the libcose are passing locally.

Just one minor comment @bergzand might be able to address, and I wouldn't mind @bergzand taking a second look on this one.

pkg/libcose/Makefile.dep Outdated
@@ -8,3 +8,9 @@ endif
ifneq (,$(filter libcose_crypt_hacl,$(USEMODULE)))
USEPKG += hacl
endif
ifneq (,$(filter libcose_crypt_monocypher,$(USEMODULE)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergzand are monocypher and c25519 still missing RIOT glue code? If its the case I might take them out of this PR for now.

Copy link
Contributor

@fjmolinas fjmolinas Jul 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaspar030 tested #11818 using moncypher and c25519 and they are not working yet.

I order not to delay I would suggest removing them from the PR, and going forward with the rest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I've removed the corresponding commit

@kaspar030 kaspar030 force-pushed the update_pkg_libcose branch from 84bf09c to 40c8953 Compare July 17, 2019 14:15
fjmolinas
fjmolinas approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran tests using #11818 as well as tests/pkg_libcose locally. ACK!

@kaspar030
Copy link
Contributor Author

&go! Thanks a lot for fixing up the tests @fjmolinas!

@kaspar030 kaspar030 merged commit 8150b01 into RIOT-OS:master Jul 18, 2019
@kaspar030 kaspar030 deleted the update_pkg_libcose branch July 18, 2019 07:44
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
4 participants
@kaspar030 @fjmolinas @kb2ma @bergzand