boards/common/nucleo: increase XTIMER_BACKOFF for STM32F103 #11975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Boards using stm32f103xx use the same custom config for xtimer which relies on the same underlying hardware timers that hang when sleeping for <20us so spin when approaching that limit.
fjmolinas
added
Type: bug
|
@cladmi might want to take a look at this one as well. |
|
Note, this does not change the |
Yes, would you want me to change it here as well? There are a couple of more |
|
I indeed had failures for these tests on the Note, you have an error in your testing procedure as you list two times the same application. It works for me with
|
|
@MrKevinWeiss you may want to test the bluepill |
No need to change it here. I just wanted to precise as you were saying The |
Yes, but two boards. But I should have specified to test both apps as well. |
You test the same app two times on each board :)
|
|
|
|
I can test on the nucleo-f103rb, it is a bit easier... |
|
Ahh sorry... fine I will test on the bluepill. |
fjmolinas
changed the title
|
|
How did you determine the number (19)? Trial and error? |
Yes |
|
@cladmi @MrKevinWeiss Thanks for the review! |
|
Thank you for addressing the failing tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR increases XTIMER_BACKOFF for all
stm32f103based board that are using customXTIMER_BACKOFFdefinitions. While testing #11809 it was seen that fornucleo-f103rb2 tests where failing because of too smallXTIMER_BACKOFFdefinitions. This PR fixes this for allstm32f103based board running on the same timer with the sameCORE_CLOCKTesting procedure
Tested on
nucleo-f103rbandbluepill:python dist/tools/compile_and_test_for_board/compile_and_test_for_board.py --jobs 2 . nucleo-f103rb --applications="tests/xtimer_usleep_short tests/xtimer_periodic_wakeup"
python dist/tools/compile_and_test_for_board/compile_and_test_for_board.py --jobs 2 . bluepill --applications="tests/xtimer_usleep_short tests/xtimer_usleep_short/"
Issues/PRs references