Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/tools/build_system_sanity_check: check BOARD set as ?= #12009

Merged
merged 2 commits into from
Aug 20, 2019
Merged

dist/tools/build_system_sanity_check: check BOARD set as ?= #12009

merged 2 commits into from
Aug 20, 2019

Conversation

cladmi
Copy link
Contributor

@cladmi cladmi commented Aug 14, 2019

Contribution description

Applications Makefile must not set 'BOARD =' unconditionally but
'BOARD ?='.

Also fix the two tests that were wrong.

Testing procedure

The check executes without error:

./dist/tools/buildsystem_sanity_check/check.sh

Without the fix it found the errors:

git revert HEAD^ --no-commit
./dist/tools/buildsystem_sanity_check/check.sh
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
Applications Makefile should use "BOARD ?="
        tests/board_microbit/Makefile:BOARD = microbit
        tests/cpu_efm32_features/Makefile:BOARD = sltb001a

This also led to not honoring the board configuration from the environment in master:

BOARD=ikea-tradfri make --no-print-directory -C tests/cpu_efm32_features/ info-debug-variable-BOARD
sltb001a

And now fixed with this PR:

BOARD=ikea-tradfri make --no-print-directory -C tests/cpu_efm32_features/ info-debug-variable-BOARD
ikea-tradfri

Issues/PRs references

Found while debugging #11477

cladmi added 2 commits August 14, 2019 17:11
@cladmi
tests: do not unconditionally set BOARD
a9e7e1b 
Remove unconditionally setting 'BOARD' to an hardwritten value.
The definition must be moved before including 'Makefile.tests_common' as
it defines 'BOARD ?= native'.
@cladmi
dist/tools/build_system_sanity_check: check BOARD set as ?=
74fbf41 
Applications Makefile must not set 'BOARD =' unconditionally but
'BOARD ?='
@cladmi cladmi mentioned this pull request Aug 14, 2019
Merged
@jcarrano jcarrano added Area: build system Area: Build system Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 14, 2019
@jcarrano jcarrano self-requested a review August 14, 2019 15:47
jcarrano
jcarrano approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@jcarrano jcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@jcarrano jcarrano merged commit d297033 into RIOT-OS:master Aug 20, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Aug 20, 2019

Thank you for the review. It should now not happen again :)

@cladmi cladmi deleted the pr/application/board_equal/bug branch August 20, 2019 15:00
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarrano jcarrano jcarrano approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@cladmi @jcarrano @kb2ma