cpu/efm32: provide periph_uart_mode #12323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilfx
added
Type: new feature
|
Needs a rebase. |
basilfx
force-pushed
the
feature/efm32_uart_modes
branch
from
93e9619 to
559fc1f
Compare
|
Rebased. |
benpicco
added
the
CI: ready for build
benpicco
reviewed
Sep 30, 2019
benpicco
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the non-standard UART mode feature, and replaces it with the
uart_modeimplementation for both UART and LEUART (only supports 8 or 9 bit frames).Testing procedure
Run
tests/periph_uart_modeand follow the test instructions. All other tests that output to the shell should still work.Here are some oscilloscope screenshots that show that the API is working (it's time-consuming to test this). I've used a custom application that just sends out 0x55.
UART 5N1:
UART 7E2:
LEUART 8N1 (default)
LEUART 8O2:
My scope show question marks whenever it cannot match the decoding settings to the actual data:
Issues/PRs references
Depends on #12322.