tests/driver_adt7310: Add explicit cast required for llvm #12345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is related to PR #11352, where I suggest to add support for Linux'
/dev/spidev
devices to the native cpu. Enabling SPI causes thetests/driver_adt7310
test to be run with the llvm toolchain for the first time.llvm doesn't allow the implicit cast to
int
in tests/driver_adt7310 (see Murdock's output).This PR fixes this by using an explicit cast. Furthermore,
abs()
is replaced withlabs()
, as the parameter may take values which exceed a 16 bitint
and could cause undefined behavior.Testing procedure
Run
BOARD=native TOOLCHAIN=llvm make -C tests/driver_adt7310 all
without and with this PR and verify that the warning disappears. The build will still fail though, as native misses the required SPI support introduced in #11352.Issues/PRs references
Required for PR #11352