Makefile.features: assert CPU is defined by BOARD/Makefile.features #12417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
CPU must now be defined by
$(RIOTBOARD)/$(BOARD)/Makefile.features
orone of its common included Makefile.features file.
The cpu
Makefile.dep
file can now automatically be included when it exists.This now forbids the previous scheme, but with an error message explaining what to do, and updating would still be compatible with a previous version too.
It was just not the good time to do it before the release.
Testing procedure
All boards in RIOT already define
CPU
as checked bydist/tools/build_system_sanity_check/check.sh
and the error are not raised when parsing the makefiles.If I comment the
CPU
line inboards/samr21-xpro/Makefile.features
then it raises an error.Issues/PRs references
Finalization of the migration done by #11477
#11477 (comment)
Depends on release 2019.10