-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/tinycbor: fix of compiler warnings "uninitialized variable used" #12505
pkg/tinycbor: fix of compiler warnings "uninitialized variable used" #12505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, just fixes a compiler warning at the cost of an additional instruction.
Can you also submit a PR to https://github.com/intel/tinycbor while you're at it, so we can drop this patch in the future.
On ESP32 and new ESP8266 platform, the compilation of the package fails since a local variable is potentially used uninitialized. Therefore, the variable is initialized with a default value.
2cca1e5
to
b6b1252
Compare
It's all green, feel free to press the button 😉 |
@benpicco It's a bad style to merge own PRs. This should always be done by a reviewer or at least by another maintainer. |
That feels like unnecessary friction. If you want to adhere to that, the maintainer would have to go through all PRs again after they already ACKed them, just to see if CI has finished running. I see that it would be a bad idea to merge if there is still an ongoing discussion, but when you got an uncontested ACK you are free to merge IMHO. |
Thanks. |
Contribution description
This PR patches the
tinycbor
package. On ESP32 and new ESP8266 (PR #11108) platforms, the compilation of the package fails since a local variable is potentially used uninitialized:With the patch provided in this PR, the variable is initialized with a default value and the according boards are removed from the balcklist.
Testing procedure
Just try to compile
tests/tinycbor
for a ESP32 board:Issues/PRs references
Required for PR #11108