Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_ipv6: fix SEGFAULT when multicasting with multiple interfaces [backport 2019.10] #12521

Merged
merged 1 commit into from
Oct 21, 2019
Merged

gnrc_ipv6: fix SEGFAULT when multicasting with multiple interfaces [backport 2019.10] #12521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,28 +563,33 @@ static void _send_multicast(gnrc_pktsnip_t *pkt, bool prep_hdr,
gnrc_pktbuf_hold(pkt, ifnum - 1);

while ((netif = gnrc_netif_iter(netif))) {
gnrc_pktsnip_t *send_pkt = pkt;
/* for !prep_hdr just use pkt as we don't duplicate IPv6 header as
* it is already filled and thus isn't filled with potentially
* interface-specific data */
if (prep_hdr) {
DEBUG("ipv6: prepare IPv6 header for sending\n");
/* need to get second write access (duplication) to fill IPv6
* header interface-local */
gnrc_pktsnip_t *tmp = gnrc_pktbuf_start_write(pkt);
* header with interface-specific data */
send_pkt = gnrc_pktbuf_start_write(pkt);

if (tmp == NULL) {
if (send_pkt == NULL) {
DEBUG("ipv6: unable to get write access to IPv6 header, "
"for interface %" PRIkernel_pid "\n", netif->pid);
gnrc_pktbuf_release(pkt);
return;
}
if (_fill_ipv6_hdr(netif, tmp) < 0) {
if (_fill_ipv6_hdr(netif, send_pkt) < 0) {
/* error on filling up header */
if (tmp != pkt) {
gnrc_pktbuf_release(tmp);
if (send_pkt != pkt) {
gnrc_pktbuf_release(send_pkt);
}
gnrc_pktbuf_release(pkt);
return;
}
}
_send_multicast_over_iface(pkt, prep_hdr, netif, netif_hdr_flags);
_send_multicast_over_iface(send_pkt, prep_hdr, netif,
netif_hdr_flags);
}
}
else {
Expand Down