Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USBUS CDC ECM: host and MCU mac addresses should differ #12676

Merged
merged 1 commit into from
Dec 5, 2019
Merged

USBUS CDC ECM: host and MCU mac addresses should differ #12676

merged 1 commit into from
Dec 5, 2019

Conversation

ant9000
Copy link
Contributor

@ant9000 ant9000 commented Nov 8, 2019 •
edited
Loading

I noticed that host and MCU mac addresses on a USBUS CDC ECM link were equal - which caused autoconfiguration of the interface to fail, and made radvd unable to work.

I make use of the newly introduced (#12592) luid_get_eui48 function to overcome the problem.

@bergzand bergzand self-requested a review November 8, 2019 14:44
@bergzand bergzand added Area: USB Area: Universal Serial Bus Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 8, 2019
@benpicco
Copy link
Contributor

benpicco commented Nov 8, 2019

luid_get_eui48() shouldn't be used directly but through eui48_get() so a board specific MAC can be supplied through a ROM chip if available.

The PR for that is #12641

@ant9000
Copy link
Contributor Author

ant9000 commented Nov 8, 2019 •
edited
Loading

luid_get_eui48() shouldn't be used directly but through eui48_get() so a board specific MAC can be supplied through a ROM chip if available.

The PR for that is #12641

Thanks a lot - I did miss that one. I'll correct and push again, as soon as it is merged.

benpicco
benpicco approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like no easy consensus is being reached on #12641.
This would be an improvement nonetheless and converting this to the 'proper' API will be trivial.

@benpicco benpicco merged commit b77ff84 into RIOT-OS:master Dec 5, 2019
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
@ant9000 ant9000 deleted the pr/usbus_cdc_ecm-mac_host-fix branch January 16, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

Assignees
No one assigned
Labels
Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
4 participants
@ant9000 @benpicco @bergzand @fjmolinas