boards/atmega_common: remove weak led_init() #12745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`led_init()` is already protected by an `#ifdef`, so no need for the weak symbol. The problem is that the weak function does not get overridden, even when the board provides it's own led_init(), resulting in no LEDs being initialized.
benpicco
added
Type: bug
This is super strange and I think this should be investigated, as other could might rely on proper handling of weak symbols as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
led_init()is already protected by an#ifdef, so no need for the weak symbol.The problem is that the weak function does not get overridden, even when the board provides it's own
led_init(), resulting in no LEDs being initialized.Testing procedure
On any ATmega board, run
tests/leds.On master, no LEDs are flashing.
With this PR they should be properly initialized again.
Issues/PRs references
discovered in #12668