Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32f1: improve rtc irq #13013

Merged
merged 1 commit into from
Jan 4, 2020
Merged

cpu/stm32f1: improve rtc irq #13013

merged 1 commit into from
Jan 4, 2020

Conversation

Hoernchen20
Copy link
Contributor

Contribution description

This PR changes the rtc irq from RTC_IRQ to RTC_ALARM_IRQ. So the cpu wakes up from Stop-Mode too.

Testing procedure

Tested on BOARD=bluepill with tests/periph_pm and tests/periph_rtc

Issues/PRs references

Fixes #11258 (comment)

@benpicco benpicco added Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Dec 29, 2019
benpicco
benpicco reviewed Dec 29, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
I have some small comments.
Also Travis is complaining about whitespace errors.

cpu/stm32f1/periph/rtc.c Outdated Show resolved Hide resolved
cpu/stm32f1/periph/rtc.c Outdated Show resolved Hide resolved
cpu/stm32f1/periph/rtc.c Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

benpicco commented Jan 1, 2020

Looks good to me, tested on blackpill-128kib.
Please squash.

fjmolinas
fjmolinas reviewed Jan 2, 2020
View reviewed changes
cpu/stm32f1/periph/rtc.c Outdated Show resolved Hide resolved
@Hoernchen20
Copy link
Contributor Author

Mmh, it seems i did something wrong with this squashing thing. Any tipps? That's new for me.

@benpicco
Copy link
Contributor

benpicco commented Jan 3, 2020

git rebase -i --autosquash master

Then select "fixup' for the commits you want to squash into the previous one.

@Hoernchen20 Hoernchen20 force-pushed the stm32f1_rtc_stop_mode branch from e27c599 to 3b966cc Compare January 4, 2020 19:01
benpicco
benpicco approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as intended.
Thank you for your contribution!

@benpicco benpicco merged commit 0d4d621 into RIOT-OS:master Jan 4, 2020
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
@benpicco benpicco mentioned this pull request Jan 23, 2020
Closed
@Hoernchen20 Hoernchen20 deleted the stm32f1_rtc_stop_mode branch February 7, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas left review comments

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.01
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoernchen20 @benpicco @fjmolinas