pkg/local.mk: fix local pkg build #13056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjmolinas
added
Type: bug
fjmolinas
force-pushed
the
pr_fix_local_pkg_13036
branch
from
5c83642 to
673ff3e
Compare
|
I removed the print since it was innacurate. |
|
Just checking: we don't assume it does the whole patching stuff, right? If not, than I can confirm it works for |
No patching if building locally ;) |
Here it should just recompile if a change is made to the code base, in your local dir. |
|
Then, together with the confirmation by @haukepetersen in #13055, I ACK. |
basilfx
approved these changes
Jan 9, 2020
|
Thanks @basilfx! Thanks for spotting the issue @haukepetersen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In #13036 a test case was missed and with the change in wasn't building local pkg. Still not sure what broke it but this at least fixes the issue. See #13055
Re-added phony since the ifdef prevents reaching the declaration in
pkg/pkg.mkTesting procedure
See #13055
Issues/PRs references
Introduced by #13036
Fixes #13055