Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: even more useless exports removed #13080

Merged
merged 7 commits into from
Feb 25, 2020
Merged

make: even more useless exports removed #13080

merged 7 commits into from
Feb 25, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jan 10, 2020 •
edited
Loading

Contribution description

This PR removes the remaining useless export of UNDEF and TARGET_ARCH variables.
A check is added in the buildsystem_sanity_check script for both of them.

Testing procedure

  • A green Murdock

Issues/PRs references

#10850, based on #13078

@aabadie aabadie added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 10, 2020
@aabadie aabadie requested a review from fjmolinas January 10, 2020 14:04
@aabadie aabadie mentioned this pull request Jan 10, 2020
Merged
@aabadie aabadie force-pushed the pr/make/remove_useless_exports_all branch 2 times, most recently from acc2fd1 to ba8a49c Compare February 7, 2020 20:13
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 7, 2020
@bergzand
Copy link
Member

@aabadie Could you please rebase this?

@aabadie aabadie force-pushed the pr/make/remove_useless_exports_all branch from ba8a49c to dca7d96 Compare February 25, 2020 08:42
@aabadie
Copy link
Contributor Author

aabadie commented Feb 25, 2020

rebased!

bergzand
bergzand approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@aabadie aabadie merged commit e119bf6 into RIOT-OS:master Feb 25, 2020
@aabadie aabadie deleted the pr/make/remove_useless_exports_all branch February 25, 2020 10:30
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 13, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees

@bergzand bergzand

Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @bergzand @leandrolanzieri