cpu/stm32/eth: Use luid_get_eui48 to generate local, non group EUI #13232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Area: cpu
miri64
changed the title
miri64
changed the title
|
Can you adapt the commit message according to the current title, please? I was very confused what a CPU is doing with a EUI-48 at first. |
miri64
added
Area: drivers
luid_get may generate non compliant EUI (MAC-address) luid_get_eui48 fixes that.
|
Done |
benpicco
reviewed
Jan 29, 2020
As long as it's clear what component is changed its fine :-) |
changed type of hwaddr to eui48 moved hwaddr declaration where it is needed
|
@benpicco did you test this? |
miri64
added
Reviewed: 1-fundamentals
|
I think it should suffice if @kfessel can confirm that the MAC address is the right way round ( |
|
Every bit but the group bit, which was cleard, stayed the same, so this bit is at the right place. I ping fe80::28xx:xxff:fexx:xxxx instead of fe80::29xx:xxff:fexx:xxxx now. So it is working. |
miri64
added
the
Reviewed: 3-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
luid_get may generate non compliant EUI (MAC-address) luid_get_eui48
fixes that.
I had MAC been generated that was marked as group (multicast) so Wireshark complained, i looked into it found that there is allready a function in Riot to generate appropriate EUI, and ei changed and testet.
It worked (no more complain by wireshark) and the interface is still answering echo requests.