Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/saml21: unblock IDLE modes by default #13551

Closed

Conversation

jue89
Copy link
Contributor

@jue89 jue89 commented Mar 4, 2020

Contribution description

I've seen that the cpu/samd21 CPU unblocks the IDLE modes by default.

I think this is also useful addition to the SAML21. The user won't notice that the CPU goes into IDLE mode when RIOT switches into the idle thread.

Testing procedure

tests/periph_pm should bring the CPU into STANDBY mode just by issuing the command unblock 1. Without this patch nothing will change after the command and the CPU stays active.

@jue89 jue89 requested a review from dylad as a code owner March 4, 2020 11:32
@jue89 jue89 force-pushed the feature/saml21-pm_layered-initial-blocker branch from 93fb44c to 038c5a0 Compare March 4, 2020 11:34
@benpicco
Copy link
Contributor

benpicco commented Mar 4, 2020

The problem is that PM_NUM_MODES is supposed to only count non-idle modes with the idle mode being implicit (and always enabled).

#13475 should already fix this.

@jue89
Copy link
Contributor Author

jue89 commented Mar 4, 2020

Yip, it does :)
This eliminates the need of this PR.

@jue89 jue89 closed this Mar 4, 2020
@jue89 jue89 deleted the feature/saml21-pm_layered-initial-blocker branch March 4, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants