net/gnrc/ipv6/nib: remove direct dependency to xtimer #13666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jue89
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
This was referenced Mar 20, 2020
miri64
reviewed
Mar 20, 2020
miri64
requested changes
Mar 20, 2020
| @@ -327,7 +327,7 @@ void gnrc_ipv6_nib_handle_pkt(gnrc_netif_t *netif, const ipv6_hdr_t *ipv6, | |||
| void gnrc_ipv6_nib_handle_timer_event(void *ctx, uint16_t type) | |||
| { | |||
| DEBUG("nib: Handle timer event (ctx = %p, type = 0x%04x, now = %ums)\n", | |||
| ctx, type, (unsigned)xtimer_now_usec() / 1000); | |||
| ctx, type, (unsigned)evtimer_now_msec()); | |||
There was a problem hiding this comment.
This might result in different values. Not sure though.
There was a problem hiding this comment.
It will differ when xtimer_now_usec() just has overflown. But I think it is okay ... it's just a debug message.
benpicco
added
Area: network
|
May I squash this PR? @miri64 Do you think your requested changes have been addressed? |
|
Yes, please squash. Keep the typo fix in a separate commit, please. The rest can become one commit (or two: one introducing the new functions one for the usage). |
This commit removes the implication that evtimer uses xtimer as timer backend.
jue89
force-pushed
the
feature/evtimer_now_msec
branch
from
6213439 to
877e0a9
Compare
miri64
reviewed
Mar 26, 2020
Thank you a lot :) |
miri64
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
While working on #13661, I realized that
gnrc_ipv6_nibimplies that evtimer pulls in xtimer. #13661 replaces xtimer with ztimer and, thus, the implication is wrong andgnrc_ipv6_nibcannot be built due to the missing xtimer.This contribution extends evtimer by getters to retrieve the current system time.
Testing procedure
tests/gnrc_ipv6_nibshould still pass.Issues/PRs references
#13661