Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocoap: make separate tree handling function #13687

Merged
merged 1 commit into from
Mar 23, 2020
Merged

nanocoap: make separate tree handling function #13687

merged 1 commit into from
Mar 23, 2020

Conversation

bergzand
Copy link
Member

Contribution description

This refactors nanocoap to seperate out the resource tree parsing. It
allows for calling the tree handler with custom resource trees. The
advantage is that a resource with COAP_MATCH_SUBTREE can parse a new
separate resource tree.

Testing procedure

Do we actually have a test covering the coap_handle_req function?

Issues/PRs references

None

@bergzand
nanocoap: make separate tree handling function
1d5010e 
This refactors nanocoap to seperate out the resource tree parsing. It
allows for calling the tree handler with custom resource trees. The
advantage is that a resource with COAP_MATCH_SUBTREE can parse a new
separate resource tree.
@bergzand bergzand added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CoAP Area: Constrained Application Protocol implementations labels Mar 23, 2020
@bergzand bergzand requested review from kb2ma and kaspar030 March 23, 2020 14:24
@bergzand bergzand mentioned this pull request Mar 23, 2020
Merged
benpicco
benpicco approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward split of the function.

@benpicco benpicco merged commit 60cb5ff into RIOT-OS:master Mar 23, 2020
@bergzand bergzand deleted the pr/nanocoap/tree_handler branch March 24, 2020 08:36
@bergzand
Copy link
Member Author

Thanks!

@bergzand bergzand mentioned this pull request Mar 24, 2020
Merged
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Mar 26, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Mar 26, 2020
@kb2ma kb2ma mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@kb2ma kb2ma Awaiting requested review from kb2ma

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@cgundogan cgundogan Awaiting requested review from cgundogan

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@bergzand @benpicco @leandrolanzieri