examples/gnrc_border_router: remove never defined USE_SLIP variable #13690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Area: build system
benpicco
approved these changes
Mar 23, 2020
leandrolanzieri
added
the
Impact: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
PR #13545 removed the definition of the variable USE_SLIP completely but it is still needed currently. If UPLINK=slip is set 'make term' throws
This pull request just removes the ifeq(1, $(USE_SLIP)) and changes it to UPLINK comparison.
Testing procedure
Go on upstream and try: make -C examples/gnrc_border_router term UPLINK=slip
The above mentioned error should occur.
Try it again with this PR - now it should work.
Issues/PRs references