-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: pkg: don't export globally GITCACHE and GIT_CACHE_DIR vars #14263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
added
Area: build system
Area: Build system
Area: pkg
Area: External package ports
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Area: tools
Area: Supplementary tools
labels
Jun 11, 2020
19 tasks
aabadie
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Jun 16, 2020
aabadie
changed the title
make: pkg: don't export GITCACHE and GIT_CACHE_DIR vars
make: pkg: don't export globally GITCACHE and GIT_CACHE_DIR vars
Jun 17, 2020
This PR doesn't seem to cause any issue with Murdock. @kaspar030, do you see any issue with the approach ? |
kaspar030
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
and please squash! |
aabadie
force-pushed
the
pr/make/git_cache_vars
branch
from
June 23, 2020 11:52
ac384f9
to
47a3f66
Compare
Rebased and squashed! |
aabadie
force-pushed
the
pr/make/git_cache_vars
branch
from
June 23, 2020 12:54
47a3f66
to
d69036f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
Area: pkg
Area: External package ports
Area: tools
Area: Supplementary tools
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently
git-cache
is only used inpkg.mk
but the corresponding variables (GITCACHE
andGIT_CACHE_DIR
) are globally exported by the build system.This PR cleans up this a little:
GITCACHE
andGIT_CACHE_DIR
variables inpkg.mk
GIT_CACHE_DIR
for the target that clones the packageNote that it's still possible to set custom GITCACHE and GIT_CACHE_DIR values from the command line.
I might have miss something related to the CI.
Testing procedure
./dist/tools/git/git-cache init
Issues/PRs references
Ticks one item in #10850