Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/lorawan: fix typo in automatic test script #14746

Merged
merged 1 commit into from
Aug 11, 2020
Merged

examples/lorawan: fix typo in automatic test script #14746

merged 1 commit into from
Aug 11, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Aug 11, 2020 •
edited
Loading

Contribution description

This PR is fixing an obvious typo in the Python test script used to test the examples/lorawan application.

Testing procedure

Build, flash and test the examples/lorawan application.

on master, you would get this (copy-pasted from #14547 (comment))

LoRaWAN Class A low-power application
=====================================
Starting join procedure
Join procedure succeeded
Sending: This is RIOT!
Sending: This is RIOT!
Sending: This is RIOT!
Sending: This is RIOT!
Sending: This is RIOT!
TESST PASSED

Issues/PRs references

Noticed that when I read #14547 (comment)

@aabadie aabadie added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: examples Area: Example Applications CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Aug 11, 2020
@aabadie aabadie merged commit 15b1816 into RIOT-OS:master Aug 11, 2020
@aabadie aabadie deleted the pr/examples/lorawan_test_typo branch August 11, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabadie @benpicco