-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tapsetup: add more features #14928
Merged
Merged
tapsetup: add more features #14928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distinguish bridge creation from tap creation.
miri64
added
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Area: network
Area: Networking
Area: tools
Area: Supplementary tools
labels
Sep 2, 2020
miri64
force-pushed
the
tools/enh/tapsetup-more
branch
from
September 2, 2020 10:22
b158fb0
to
951192c
Compare
benpicco
added
the
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
label
Sep 3, 2020
benpicco
reviewed
Sep 3, 2020
benpicco
reviewed
Sep 3, 2020
Looks good and works as expected. I'm trusting your testing on FreeBSD. Please squash. |
benpicco
approved these changes
Sep 8, 2020
miri64
force-pushed
the
tools/enh/tapsetup-more
branch
from
September 8, 2020 11:51
3b9afc3
to
5fea5fc
Compare
Squashed |
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: network
Area: Networking
Area: tools
Area: Supplementary tools
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
CI: skip compile test
If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs
Type: enhancement
The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is a first step towards fixing by adding new functionalities to the
tapsetup
script (which I plan to use late for the common approach or at least some parts of it):get_bridge
python implementation throughout the tests)Testing procedure
I tested this on both Linux and FreeBSD (using the vagrant box provided at
/dist/tools/vagrant/freebsd
) but since the commands I used for FreeBSD are the same on OSX, it should also work there as well.should list the bridge
tap0
belongs to and its interfaces. If you use the name of the bridge,tapbr0
on Linux,bridge0
on FreeBSD, it should work as well.should create a bridge with forwarding enabled
will revert that.
should add the addresses
2001:db8::1/48
andfe80::1/128
to the bridge when it is createdshould revert it.
should add a route to
2001:db8::/48
viafe80::2
and the bridge andshould revert it again.
You may also try different combinations of the command.
Issues/PRs references
#14618