tests/periph_timer_{periodic, short_relative_set}: Drop include of xtimer.h
#15035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including xtimer.h without using the xtimer module results in issues on the waspmote-pro. Thus, drop the include.
Including xtimer.h without using the xtimer module results in issues on the waspmote-pro. Thus, drop the include.
maribu
added
Type: bug
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Sep 16, 2020
|
Hooray, I think this was the last dependency to #14799. Thank you very much :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
These tests don't use the
xtimermodule, but still includextimer.h. This leads to compilation errors in #14799. This drops the#includeofxtimer.hand replicates the fall-back logic inxtimer.hneeded for compilation.This is certainly not the best and final solution. IMO, it would be nice to add a function to
periph_timerthat allows iterating over supported frequencies. But let's get this in as intermediate solution until such a feature is added.Testing procedure
Generated binaries should not change.
Issues/PRs references
Split out of #14799