Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdev_test_ieee802154: initial import of an IEEE 802.15.4 device mock #16020

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

netdev_test_ieee802154: initial import of an IEEE 802.15.4 device mock #16020

wants to merge 2 commits into from

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 16, 2021

Contribution description

This provides netdev_test_ieee802154, an extension for netdev_test to initialize the get callbacks for those netopts that gnrc_netif expects to be set.

Testing procedure

Unittests for this feature are provided. Just run

make -C tests/netdev_test_ieee802154 flash test

for a board of your choice.

A GNRC-less variant (without the use of gnrc_nettype_sixlowpan) can also be tested using

TEST_PROTO=0 make -C tests/netdev_test_ieee802154 flash test

Issues/PRs references

#15694 (comment)

@miri64 miri64 added Area: network Area: Networking Area: tests Area: tests and testing framework Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Feb 16, 2021
@miri64 miri64 requested a review from maribu February 16, 2021 10:23
@miri64 miri64 force-pushed the netdev_test/feat/ieee802154 branch 2 times, most recently from d64a867 to 46a1260 Compare February 16, 2021 10:38
@miri64 miri64 mentioned this pull request Feb 16, 2021
Merged
2 tasks
@benpicco benpicco requested a review from jia200x February 16, 2021 10:41
maribu
maribu reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please squash right away.

sys/net/netdev_test/ieee802154/netdev_test_ieee802154.c Outdated Show resolved Hide resolved
sys/net/netdev_test/ieee802154/netdev_test_ieee802154.c Outdated Show resolved Hide resolved
sys/net/netdev_test/ieee802154/netdev_test_ieee802154.c Outdated Show resolved Hide resolved
tests/netdev_test_ieee802154/main.c Outdated Show resolved Hide resolved
tests/netdev_test_ieee802154/main.c Outdated Show resolved Hide resolved
@fjmolinas
Copy link
Contributor

ping @miri64

@miri64 miri64 force-pushed the netdev_test/feat/ieee802154 branch from 46a1260 to 5ee8ac7 Compare May 4, 2021 10:01
@miri64
Copy link
Member Author

miri64 commented May 4, 2021

First, I rebased, since I believe the NETOPT_MAX_PACKET_SIZE value already does not exist in master (so I test this more confidently).

@miri64
Copy link
Member Author

miri64 commented May 4, 2021

And addressed @maribu's change request.

@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2021
benpicco
benpicco approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might still be useful, feel free to squash

@miri64 miri64 force-pushed the netdev_test/feat/ieee802154 branch from 456c209 to 9cae200 Compare September 3, 2021 09:15
@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

Squashed

@github-actions github-actions bot added the Area: sys Area: System label Sep 3, 2021
@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

I think #16776 might have broken something :-/

-- running on worker mobi6.inet.haw-hamburg.de-20 thread 1, build number 236126.
make: Entering directory '/tmp/dwq.0.8076410412997762/7f4926df34d1c5ff634a64729f3c8519/tests/driver_feetech'
make: command: Command not found
make: command: Command not found
make: command: Command not found
/tmp/dwq.0.8076410412997762/7f4926df34d1c5ff634a64729f3c8519/tests/driver_feetech/../../Makefile.include:340: Neither wget nor curl is installed!
make: command: Command not found
make: command: Command not found
/tmp/dwq.0.8076410412997762/7f4926df34d1c5ff634a64729f3c8519/tests/driver_feetech/../../Makefile.include:358: Neither unzip nor 7z is installed.
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
/bin/sh: 0: Illegal option -g
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
make: command: Command not found
[…]

@miri64 miri64 mentioned this pull request Sep 3, 2021
Merged
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2021
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2021
benpicco
benpicco reviewed Sep 3, 2021
View reviewed changes
sys/include/net/netdev_test/ieee802154.h
* constraints, this mock is exactly usable as a @ref sys_netdev_test would be.
* The initialized get callbacks are the ones for the following options:
* - @ref NETOPT_DEVICE_TYPE (returns `value == NETDEV_TYPE_IEEE802154`)
* - @ref NETOPT_MAX_PACKET_SIZE (returns `value == 102U`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NETOPT_MAX_PACKET_SIZE no longer exists

@benpicco benpicco removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2021
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2021
@benpicco
Copy link
Contributor

benpicco commented Sep 3, 2021

looks like #16109 could come in handy here 😉

@miri64
Copy link
Member Author

miri64 commented Sep 3, 2021

I'll just do it with my usual Copy, Paste & and vim-macro magic tactic for now ;-)

@miri64 miri64 force-pushed the netdev_test/feat/ieee802154 branch from 9cae200 to 1202c97 Compare September 3, 2021 13:15
@OlegHahm
Copy link
Member

OlegHahm commented Apr 8, 2022

@miri64, ping :)

@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Nov 2, 2022
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 2, 2022
@miri64
Copy link
Member Author

miri64 commented Nov 2, 2022

Does this still make sense with IEEE 802.15.4 HAL?

@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Nov 2, 2022
@miri64
Copy link
Member Author

miri64 commented May 30, 2023

Does this still make sense with IEEE 802.15.4 HAL?

Ping @jia200x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu left review comments

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@smlng smlng Awaiting requested review from smlng

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miri64 @fjmolinas @benpicco @OlegHahm @maribu @MrKevinWeiss