Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_rpl: harden validation routine for options #16081

Merged
merged 1 commit into from
Feb 24, 2021
Merged

gnrc_rpl: harden validation routine for options #16081

merged 1 commit into from
Feb 24, 2021

Conversation

cgundogan
Copy link
Member

Contribution description

Hardens the validation of option lengths.
Thanks @nmeum for reporting this!

Testing procedure

  1. as specified in gnrc_rpl: missing bounds checks in gnrc_rpl_validation_options #16062
  2. run a small RPL network (native will suffice) and verify that ping between nodes (use the global IPv6 address) still works. nib route should show the correct routing entries.

Issues/PRs references

fixes #16062

@cgundogan cgundogan added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Feb 23, 2021
nmeum
nmeum approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@nmeum nmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

benpicco
benpicco approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy-ACK

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 24, 2021
@benpicco benpicco merged commit 930e760 into RIOT-OS:master Feb 24, 2021
@nmeum nmeum mentioned this pull request Feb 24, 2021
Open
@cgundogan cgundogan deleted the pr/rpl_options_fix branch February 24, 2021 18:18
@kaspar030 kaspar030 added this to the Release 2021.04 milestone Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmeum nmeum nmeum approved these changes

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2021.04
Development

Successfully merging this pull request may close these issues.

gnrc_rpl: missing bounds checks in gnrc_rpl_validation_options
4 participants
@cgundogan @benpicco @nmeum @kaspar030