Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_sixlowpan_frag_sfr_congure: add congure_quic support #16159

Merged

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 5, 2021

Contribution description

This provisions GNRC's 6LoWPAN SFR implementation with the CongURE implementation of QUIC. It also adds that implementation to the tests/gnrc_sixlowpan_frag_sfr_congure_impl test application.

Testing procedure

The test tests/gnrc_sixlowpan_frag_sfr_congure_impl where extended to support congure_quic:

CONGURE_IMPL=congure_quic make -C tests/gnrc_sixlowpan_frag_sfr_congure_impl

Ping some nodes with at least 1 hop separation with large payloads. Exchange between should work.

Issues/PRs references

Depends on #15952 (merged) and #16158 (merged) and their respective dependencies.

PR dependency graph

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 5, 2021
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_quic/feat/initial branch from 1d427c7 to 8957350 Compare May 6, 2021 15:21
@miri64
Copy link
Member Author

miri64 commented May 6, 2021

Rebased and squashed to current master.

@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 22, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@miri64 miri64 removed the State: stale State: The issue / PR has no activity for >185 days label Mar 2, 2022
@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_quic/feat/initial branch from 8957350 to e288d54 Compare October 25, 2022 11:01
@miri64 miri64 requested a review from MrKevinWeiss as a code owner October 25, 2022 11:01
@github-actions github-actions bot added Area: build system Area: Build system Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels Oct 25, 2022
@miri64
Copy link
Member Author

miri64 commented Oct 25, 2022

Rebased and adopted for current master and dependencies, needs #18798 though, for the test application to link.

@benpicco
Copy link
Contributor

benpicco commented Mar 1, 2023

Needs a rebase

@miri64 miri64 force-pushed the gnrc_sixlowpan_frag_sfr_congure_quic/feat/initial branch from e288d54 to 753e0c8 Compare March 1, 2023 12:15
@github-actions github-actions bot removed Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Mar 1, 2023
@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 1, 2023
@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

Rebased to current master

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 1, 2023
@riot-ci
Copy link

riot-ci commented Mar 1, 2023

Murdock results

✔️ PASSED

753e0c8 tests: add congure_quic to SFR CongURE test

Success Failures Total Runtime
6902 0 6902 09m:42s

Artifacts

@miri64
Copy link
Member Author

miri64 commented Mar 1, 2023

bors merge

(no sense in waiting for #16170, I already know it will cause a syntactic merge conflict with this one)

@bors
Copy link
Contributor

bors bot commented Mar 1, 2023

Build succeeded:

@bors bors bot merged commit 4e646fe into RIOT-OS:master Mar 1, 2023
@miri64 miri64 deleted the gnrc_sixlowpan_frag_sfr_congure_quic/feat/initial branch March 1, 2023 15:30
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants