cpu/stm32/periph_eth: Provide confirm_send() #16262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make use of `netdev_driver_t::send_confirm` when not `NULL`
- assume when `send_confirm` is `NULL` that `send()` blocks until completion
- otherwise, `gnrc_netif will block via `core_thread_flags` until the TX
completed event is issued, while also handling any IRQs raised during TX
- use `core_thread_flags` instead of `core_msg` to pass on events to the netif
thread
- this makes sure IRQs are no longer lost, making `gnrc_netif_events`
obsolete. Consequently, it is removed
- this allows any type of event being issues for IRQ context, which is
beneficial for peripheral drivers
only release outgoing frame with legacy drivers, as gnrc_netif does so with new non-blocking API.
Use PRIu32 instead of lu to make LLVM happy.
maribu
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
jeandudey
added
Area: cpu
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
stale
bot
removed
the
State: stale
github-actions
bot
added
Area: build system
|
In my local branches the code has evolved quite a bit further. I will open a new PR when the dependencies are in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
sys/net/gnrc/netif/ethernetto allow Ethernet drivers to provide the new netdev APIcpu/stm32/periph_ethto provideconfirm_send()Testing procedure
E.g.
examples/gnrc_networkingon e.g. a Nucleo-F767Zi should still work.Issues/PRs references
Depends on: