Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/periph_timer: add timer_query_freqs() #16349

Merged
merged 2 commits into from
Dec 5, 2023
Merged

drivers/periph_timer: add timer_query_freqs() #16349

merged 2 commits into from
Dec 5, 2023

Conversation

maribu
Copy link
Member

@maribu maribu commented Apr 19, 2021 •
edited
Loading

Contribution description

Allow accessing supported timer frequencies with a dedicated API.
This API needs to be implemented per platform and is available with
the feature periph_timer_query_freqs.

Testing procedure

The test in tests/periph_timer has been extended to make use of the new API to increase test coverage.

Issues/PRs references

Implementations:

@maribu maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers Area: timers Area: timer subsystems labels Apr 19, 2021
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
@benpicco
Copy link
Contributor

Please squash & rebase

@maribu maribu force-pushed the periph_timer_query_freq branch from bcd8d5a to 7c0db04 Compare August 31, 2021 14:16
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Platform: AVR Platform: This PR/issue effects AVR-based platforms and removed Area: timers Area: timer subsystems labels Aug 31, 2021
@maribu maribu force-pushed the periph_timer_query_freq branch from 7c0db04 to 70a06a2 Compare August 31, 2021 14:17
@maribu maribu added Area: timers Area: timer subsystems and removed Platform: AVR Platform: This PR/issue effects AVR-based platforms labels Aug 31, 2021
maribu
maribu commented Aug 31, 2021
View reviewed changes
tests/periph_timer/main.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added Platform: AVR Platform: This PR/issue effects AVR-based platforms and removed Area: timers Area: timer subsystems labels Aug 31, 2021
@maribu
Copy link
Member Author

maribu commented Aug 31, 2021

Please squash & rebase

Done. Thanks for the reminder!

@maribu maribu force-pushed the periph_timer_query_freq branch from 8dede12 to 2a75413 Compare December 5, 2023 09:15
@github-actions github-actions bot removed Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: cpu Area: CPU/MCU ports labels Dec 5, 2023
This was referenced Dec 5, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
kaspar030
kaspar030 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

(please change to plural as discussed - timer_query_freq() -> timer_query_freqs())

@maribu maribu force-pushed the periph_timer_query_freq branch from 2a75413 to 3474c40 Compare December 5, 2023 09:58
@maribu maribu changed the title drivers/periph_timer: add timer_query_freq() drivers/periph_timer: add timer_query_freqs() Dec 5, 2023
@maribu maribu enabled auto-merge December 5, 2023 09:59
@maribu maribu mentioned this pull request Dec 5, 2023
Closed
maribu added 2 commits December 5, 2023 16:07
@maribu
drivers/periph_timer: add periph_timer_query_freqs
b917807 
Allow accessing supported timer frequencies with a dedicated API.
This API needs to be implemented per platform and is available with
the feature periph_timer_query_freqs.
@maribu
tests/periph_timer: use periph_timer_query_freqs
3bc6494 
If the feature periph_timer_query_freqs is provided, use the
corresponding function to iterate over all supported frequencies to
increase test coverage.
@maribu maribu force-pushed the periph_timer_query_freq branch from 3474c40 to 3bc6494 Compare December 5, 2023 15:07
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Dec 5, 2023
@maribu maribu added this pull request to the merge queue Dec 5, 2023
Merged via the queue into RIOT-OS:master with commit 0097692 Dec 5, 2023
28 checks passed
@maribu maribu deleted the periph_timer_query_freq branch December 5, 2023 19:52
@maribu
Copy link
Member Author

maribu commented Dec 5, 2023

🎉 thx!

@kfessel kfessel mentioned this pull request Dec 6, 2023
Merged
@maribu maribu mentioned this pull request Dec 6, 2023
Merged
1 task
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas left review comments

@leandrolanzieri leandrolanzieri leandrolanzieri left review comments

@kaspar030 kaspar030 kaspar030 approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kYc0o kYc0o Awaiting requested review from kYc0o

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@roberthartung roberthartung Awaiting requested review from roberthartung

@smlng smlng Awaiting requested review from smlng

@miri64 miri64 Awaiting requested review from miri64

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d

@benpicco benpicco Awaiting requested review from benpicco

@dylad dylad Awaiting requested review from dylad

@keestux keestux Awaiting requested review from keestux

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
7 participants
@maribu @benpicco @riot-ci @kaspar030 @leandrolanzieri @fjmolinas @MrKevinWeiss