Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32: add rtc_mem #16802

Merged
merged 1 commit into from
Sep 8, 2021
Merged

cpu/stm32: add rtc_mem #16802

merged 1 commit into from
Sep 8, 2021

Conversation

fjmolinas
Copy link
Contributor

Contribution description

WIP of rtc_mem implementation for stm32, just to see if the API works fine for stm32 BOARDs as well.

Testing procedure

Both tests/periph_rtc and tests/periph_rtt have been adapted to make use of the feature and to ensure it does not interfere with normal RTC/RTT alarms.

Need to see if those REGS do not exist on some families....

Issues/PRs references

Depends on #16758

@fjmolinas fjmolinas added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 3, 2021
@fjmolinas fjmolinas requested a review from benpicco September 3, 2021 09:18
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Sep 3, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from 60cde38 to 71a06b2 Compare September 6, 2021 15:17
@github-actions github-actions bot removed Area: drivers Area: Device drivers Area: tests Area: tests and testing framework Area: Kconfig Area: Kconfig integration labels Sep 6, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from 71a06b2 to 6a56557 Compare September 6, 2021 17:19
@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Sep 6, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from 6a56557 to 9ff7164 Compare September 6, 2021 17:24
benpicco
benpicco reviewed Sep 6, 2021
View reviewed changes
cpu/stm32/periph/rtc_all.c Outdated Show resolved Hide resolved
benpicco
benpicco reviewed Sep 6, 2021
View reviewed changes
cpu/stm32/periph/rtc_all.c Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

benpicco commented Sep 6, 2021

ah Kconfig needs an update too

@github-actions github-actions bot added the Area: Kconfig Area: Kconfig integration label Sep 6, 2021
benpicco
benpicco reviewed Sep 6, 2021
View reviewed changes
cpu/stm32/periph/rtc_mem.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Area: tools Area: Supplementary tools label Sep 7, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from 95abaa4 to a82b6d1 Compare September 7, 2021 06:54
@fjmolinas fjmolinas requested a review from kaspar030 as a code owner September 7, 2021 06:54
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components and removed Area: tools Area: Supplementary tools labels Sep 7, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from a82b6d1 to 60e87e1 Compare September 7, 2021 06:59
@github-actions github-actions bot added Area: build system Area: Build system and removed Area: CI Area: Continuous Integration of RIOT components labels Sep 7, 2021
@fjmolinas fjmolinas force-pushed the pr_stm32_periph_rtc_mem branch from c2e9186 to 8e17b67 Compare September 7, 2021 08:06
@github-actions github-actions bot removed the Area: build system Area: Build system label Sep 7, 2021
benpicco
benpicco approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on nucleo-l031k6 and works fine!

@benpicco benpicco merged commit 69b7db2 into RIOT-OS:master Sep 8, 2021
@fjmolinas fjmolinas deleted the pr_stm32_periph_rtc_mem branch September 14, 2021 06:00
@benpicco benpicco mentioned this pull request Sep 14, 2021
Open
@benpicco benpicco added this to the Release 2021.10 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@smlng smlng Awaiting requested review from smlng

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2021.10
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @benpicco