Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: import PIR motion sensor driver #1714

Merged
merged 1 commit into from
Sep 26, 2014
Merged

drivers: import PIR motion sensor driver #1714

merged 1 commit into from
Sep 26, 2014

Conversation

LudwigKnuepfer
Copy link
Member

TODO:
- [x] blacklist boards without GPIO

  • make private API static
  • remove Hauke style incompatibility catching
  • lookup sensible default pins for boards

@LudwigKnuepfer LudwigKnuepfer added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 25, 2014
@LudwigKnuepfer
Copy link
Member Author

Bug found on the go: arduino-due hard-faults in the interrupt driven mode of this test.

@LudwigKnuepfer LudwigKnuepfer added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 25, 2014
@LudwigKnuepfer LudwigKnuepfer changed the title drivers: import PIR motion sensor driver WIP: drivers: import PIR motion sensor driver Sep 25, 2014
Kijewski
Kijewski reviewed Sep 25, 2014
View reviewed changes
drivers/pir/pir.c

int pir_activate_int(pir_t *dev);
void pir_callback(void *dev);
void pir_send_msg(pir_t *dev, pir_event_t event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal but not static?

LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 25, 2014
@LudwigKnuepfer
SQUASHME: remove missing GPIO workaround
df37c98 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 25, 2014
@LudwigKnuepfer
SQUASHME: make private API static
ffdcb9d 
Addresses RIOT-OS#1714 (comment)
@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 26, 2014
LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
@LudwigKnuepfer
SQUASHME: remove missing GPIO workaround
2cb5976 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
@LudwigKnuepfer
SQUASHME: make private API static
3b9c60f 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
@LudwigKnuepfer
SQUASHME: remove missing GPIO workaround
19a404b 
Addresses RIOT-OS#1714 (comment)
LudwigKnuepfer added a commit to LudwigKnuepfer/RIOT that referenced this pull request Sep 26, 2014
@LudwigKnuepfer
SQUASHME: make private API static
199c820 
Addresses RIOT-OS#1714 (comment)
@LudwigKnuepfer LudwigKnuepfer mentioned this pull request Sep 26, 2014
Merged
@LudwigKnuepfer LudwigKnuepfer removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 26, 2014
@LudwigKnuepfer LudwigKnuepfer changed the title WIP: drivers: import PIR motion sensor driver drivers: import PIR motion sensor driver Sep 26, 2014
haukepetersen
haukepetersen reviewed Sep 26, 2014
View reviewed changes
drivers/include/pir.h
* @brief device descriptor for a PIR sensor
*/
typedef struct {
gpio_t gpio_dev; /**< GPIO device which is used */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indention

@LudwigKnuepfer
drivers: import PIR motion sensor driver
e75dd40 
Includes an application for manual testing.
@haukepetersen
Copy link
Contributor

Looking great, nice effort for the documentation!

ACK (when squashed)

@LudwigKnuepfer
Copy link
Member Author

squashed

@LudwigKnuepfer LudwigKnuepfer removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 26, 2014
LudwigKnuepfer added a commit that referenced this pull request Sep 26, 2014
@LudwigKnuepfer
Merge pull request #1714 from LudwigOrtmann/add_driver_pir
7e86044 
drivers: import PIR motion sensor driver
@LudwigKnuepfer LudwigKnuepfer merged commit 7e86044 into RIOT-OS:master Sep 26, 2014
@LudwigKnuepfer LudwigKnuepfer deleted the add_driver_pir branch September 26, 2014 18:57
@miri64 miri64 mentioned this pull request Sep 29, 2014
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LudwigKnuepfer @haukepetersen @Kijewski