Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/relic: bump to current master #17161

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

kaspar030
Copy link
Contributor

Contribution description

This bumps relic to a current version.
The current one has a couple of compile errors with gcc 11, which are resolved upstream.
(unfortunately not in the latest release 0.50.0, so updating to master instead).

Some relic defines changed names, so the test needed an update. I verified each of the changes.

Testing procedure

I tested this on native and nrf52840dk using tests/pkg_relic.

Issues/PRs references

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 8, 2021
@kaspar030 kaspar030 self-assigned this Nov 8, 2021
@github-actions github-actions bot added Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Nov 8, 2021
@kaspar030 kaspar030 requested a review from OlegHahm November 8, 2021 22:39
Comment on lines 18 to +21
+#elif SEED == RIOTRND && defined(MODULE_RANDOM)
+
+ random_bytes(buf,SEED_SIZE);
+ void random_bytes(uint8_t *buf, size_t size);
+ random_bytes(buf, RLC_RAND_SEED);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we try to send that patch upstream yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea

@MrKevinWeiss
Copy link
Contributor

I guess the nucleo-f303k8 and the nucleo-f334r8 don't fit anymore...

@kaspar030
Copy link
Contributor Author

I guess the nucleo-f303k8 and the nucleo-f334r8 don't fit anymore...

blacklisted and amended

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, trusting @kaspar030 testing

@MrKevinWeiss MrKevinWeiss merged commit ff8983c into RIOT-OS:master Nov 10, 2021
@kaspar030 kaspar030 deleted the update_pkg_relic branch November 16, 2021 21:52
@fjmolinas fjmolinas added this to the Release 2022.01 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants