gnrc/ipv6_auto_subnets: add CONFIG_GNRC_IPV6_AUTO_SUBNETS_STATIC option #17429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
cgundogan,
haukepetersen,
miri64 and
PeterKietzmann
as code owners
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
gnrc/ipv6_auto_subnets-static
branch
from
329b770 to
67bf76b
Compare
Would be great if |
benpicco
force-pushed
the
gnrc/ipv6_auto_subnets-static
branch
from
67bf76b to
e484241
Compare
benpicco
removed
the
CI: ready for build
|
For that I would first need to add Kconfig to that subsystem |
miri64
requested changes
Oct 25, 2022
sys/net/gnrc/routing/ipv6_auto_subnets/gnrc_ipv6_auto_subnets.c
Outdated
Show resolved
Hide resolved
sys/net/gnrc/routing/ipv6_auto_subnets/gnrc_ipv6_auto_subnets.c
Outdated
Show resolved
Hide resolved
In situations with high packet loss, if all sync packets are lost, conflicting subnets will be configured. If the network is static, this can be prevented by always using the highest number of subnets that has been observed. This assumes no nodes are physically added / removed from the network.
benpicco
force-pushed
the
gnrc/ipv6_auto_subnets-static
branch
from
e484241 to
b068bd3
Compare
miri64
added
Type: enhancement
Murdock results✔️ PASSED b068bd3 gnrc/ipv6_auto_subnets: add CONFIG_GNRC_IPV6_AUTO_SUBNETS_STATIC option
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
In situations with high packet loss, if all sync packets are lost, conflicting subnets will be configured.
If the network is static, this can be prevented by always using the highest number of subnets that has been observed.
This assumes no nodes are physically added / removed from the network. This is typically given in a wired sensor network.
Testing procedure
Add
to the
Makefileofexamples/gnrc_networking_subnets.Configure a topology with multiple routers on the same subnet. Now even if you remove a router, the subnet assignments should not change.
Issues/PRs references