Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc_netif: make auto-config of compression context optional #17678

Merged
merged 1 commit into from
May 24, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Feb 18, 2022

Contribution description

For a set of my currently ongoing experiments it is important that the 6LoWPAN header stays roughly the same over all hops. With global addresses this can easily be achieved by not configuring a compression context. However, when using a border router with UHCP or DHCPv6, the compression context will be configured automatically and when you try to delete it, it is most often to late, as the prefix and the compression contexts are already disseminated throughout the network (and any further auto config message for the prefix might re-add it).

This change makes the auto-configuration of the compression context by setting the Kconfig variable CONFIG_GNRC_NETIF_IPV6_DO_NOT_COMP_PREFIX to false.

Testing procedure

Flash and run the examples/gnrc_border_router twice: Once as is, and once with the new option set (e.g. by using make menuconfig. Once a global prefix is configured (use ifconfig to check) use 6ctx to check: for the untouched binary, 6ctx should show the prefix as compression context 0, for when CONFIG_GNRC_NETIF_IPV6_DO_NOT_COMP_PREFIX=y the table should be empty.

Issues/PRs references

None

@miri64 miri64 requested a review from benpicco February 18, 2022 16:31
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System labels Feb 18, 2022
@benpicco
Copy link
Contributor

I think #17594 does the same, it will just allow to completely disable the module instead.

@miri64
Copy link
Member Author

miri64 commented Feb 18, 2022

I think #17594 does the same, it will just allow to completely disable the module instead.

You still might want to configure compression manually, so I don't think it is the same.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@miri64 miri64 force-pushed the gnrc_netif/enh/optional-comp-ctx branch from 11114e9 to 3d819ce Compare May 24, 2022 10:42
@miri64
Copy link
Member Author

miri64 commented May 24, 2022

Squashed

@miri64 miri64 enabled auto-merge May 24, 2022 10:51
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 24, 2022
@miri64 miri64 merged commit 3e53180 into RIOT-OS:master May 24, 2022
@miri64 miri64 deleted the gnrc_netif/enh/optional-comp-ctx branch May 25, 2022 06:33
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label May 25, 2022
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants