Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add missing --locked to C2Rust installation instructions #17694

Closed
wants to merge 1 commit into from
Closed

doc: Add missing --locked to C2Rust installation instructions #17694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/doxygen/src/using-rust.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ and needs some patches applied:
```shell
$ rustup install nightly-2019-12-05
$ rustup component add --toolchain nightly-2019-12-05 rustfmt rustc-dev
$ cargo +nightly-2019-12-05 install c2rust
$ cargo +nightly-2019-12-05 install --locked c2rust
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, isn't this either-or? either install from crates.io (using this line), or from the checked-out path? and, older cargo versions don't support/honor "--locked" when installing from crates.io (vs. local path), IIRC.

@chrysn knows more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird error in the documentation I wrote -- that line shouldn't be there in the first place, the relevant install is 3 lines down where I fixed the --locked in https://github.com/RIOT-OS/RIOT/pull/17504/files

(The c2rust uploaded to crates.io is also not the one working, no clue what went wrong there precisely; that changed line should just go away)

$ git clone https://github.com/chrysn-pull-requests/c2rust -b for-riot
$ cd c2rust
$ cargo +nightly-2019-12-05 install --locked --path c2rust
Expand Down