sys/syscalls: make gettimeofday() implementation optional #17733

fjmolinas · 2022-03-02T09:03:25Z

Contribution description

A follow-up to #17732 to not force 64bit on all syscalls users.

With this PR the users of ztimer64 should be limited to:

Revisited list of apps using ztimer64:

for app in examples/* tests/*; do make -C ${app} info-modules | if grep -q ztimer64; then echo ${app};fi;done

examples/ccn-lite-relay
examples/cord_ep
examples/cord_lc
examples/dtls-echo
examples/dtls-sock
examples/dtls-wolfssl
examples/gcoap_dtls
examples/gnrc_networking_mac
examples/lua_basic
examples/lua_REPL
examples/openthread
examples/posix_select
examples/wasm
tests/cpp11_condition_variable
tests/cpp11_mutex
tests/cpp11_thread
tests/driver_ltc4150
tests/driver_pir
tests/gnrc_gomach
tests/lua_loader
tests/nimble_autoconn_ccnl
tests/pkg_arduino_sdi_12
tests/pkg_flatbuffers
tests/pkg_tensorflow-lite
tests/pkg_tinydtls_sock_async
tests/pkg_wolfcrypt-ed25519-verify
tests/pkg_wolfssl
tests/posix_semaphore
tests/pthread
tests/pthread_barrier
tests/pthread_cleanup
tests/pthread_condition_variable
tests/pthread_cooperation
tests/pthread_flood
tests/pthread_rwlock
tests/pthread_tls
tests/saul_drivers
tests/sema
tests/sntp
tests/sys_fido2_ctap
tests/unittests
tests/ztimer64_msg

Testing procedure

Green Murdock, although should probably wait for #17721 or cherry-pick f7f7a93 to test for missing dependencies.

Issues/PRs references

Follow up to #17732
Related to #17721 and #17365

fjmolinas · 2022-03-10T09:26:53Z

I think I'll wait for #17719 and then rebase on #17721.

fjmolinas · 2022-03-23T07:13:56Z

@kaspar030 @kfessel all green here, would be good to get this in to reduce ztimer64 users!

kfessel

I think the pseudo module could have a shorter name. libc_gettimeofday

cpu/native/Makefile.dep

makefiles/pseudomodules.inc.mk

fjmolinas · 2022-03-24T08:37:50Z

@kfessel changes addressed!

kfessel

two small nitpicks in Makefile.dep other than that this is good to go

u can skip the murdock

sys/Makefile.dep

Conditionally implement gettimeofday() if module is included, this avoids including ztimer64 even when not needed

kfessel

green murdock and good change

benpicco · 2022-04-27T21:46:01Z

This breaks esp32 😢
RIOT-OS/Release-Specs#247 (comment)

fjmolinas added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 2, 2022

fjmolinas requested a review from kfessel March 2, 2022 09:03

fjmolinas requested review from leandrolanzieri, jia200x, cgundogan, miri64, haukepetersen and PeterKietzmann as code owners March 2, 2022 09:03

github-actions bot added Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration Area: network Area: Networking Area: sys Area: System Area: timers Area: timer subsystems Platform: native Platform: This PR/issue effects the native platform labels Mar 2, 2022

fjmolinas force-pushed the pr_gettimeofday_64_bit branch from 1a64bc1 to 0a5be52 Compare March 4, 2022 07:20

fjmolinas requested a review from kaspar030 as a code owner March 4, 2022 07:20

fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Mar 4, 2022

github-actions bot added Area: CI Area: Continuous Integration of RIOT components Area: network Area: Networking and removed Area: network Area: Networking labels Mar 4, 2022

fjmolinas requested review from smlng, aabadie and MichelRottleuthner as code owners March 4, 2022 07:28

fjmolinas force-pushed the pr_gettimeofday_64_bit branch from 4ea3423 to 9bd2011 Compare March 4, 2022 07:29

github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework and removed Area: CI Area: Continuous Integration of RIOT components labels Mar 4, 2022

fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 4, 2022

github-actions bot removed the Area: timers Area: timer subsystems label Mar 10, 2022

fjmolinas force-pushed the pr_gettimeofday_64_bit branch from e285c2a to f2bd476 Compare March 10, 2022 07:15

fjmolinas removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 10, 2022

fjmolinas force-pushed the pr_gettimeofday_64_bit branch from f2bd476 to 0c5a316 Compare March 21, 2022 15:58

fjmolinas added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 21, 2022

github-actions bot added Area: timers Area: timer subsystems and removed Area: doc Area: Documentation labels Mar 21, 2022

benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 21, 2022

fjmolinas force-pushed the pr_gettimeofday_64_bit branch 3 times, most recently from 417b260 to 9b7ed6f Compare March 22, 2022 17:04

github-actions bot removed the Area: timers Area: timer subsystems label Mar 22, 2022

kfessel reviewed Mar 23, 2022

View reviewed changes

cpu/native/Makefile.dep Outdated Show resolved Hide resolved

makefiles/pseudomodules.inc.mk Outdated Show resolved Hide resolved

fjmolinas force-pushed the pr_gettimeofday_64_bit branch 2 times, most recently from 618c761 to c7fce7c Compare March 24, 2022 07:07

kfessel reviewed Mar 24, 2022

View reviewed changes

sys/Makefile.dep Outdated Show resolved Hide resolved

sys/Makefile.dep Outdated Show resolved Hide resolved

sys/syscalls: add libc_gettimeofday

0819660

Conditionally implement gettimeofday() if module is included, this avoids including ztimer64 even when not needed

fjmolinas force-pushed the pr_gettimeofday_64_bit branch from c7fce7c to 0819660 Compare March 24, 2022 10:36

fjmolinas added the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Mar 24, 2022

kfessel changed the title ~~sys/syscalls: empty gettimeofday() unless 64bit present~~ sys/syscalls: make gettimeofday() implementation optional Mar 24, 2022

kfessel approved these changes Mar 24, 2022

View reviewed changes

fjmolinas enabled auto-merge March 24, 2022 13:22

fjmolinas merged commit b91b984 into RIOT-OS:master Mar 24, 2022

OlegHahm added this to the Release 2022.04 milestone Apr 25, 2022

fjmolinas deleted the pr_gettimeofday_64_bit branch April 28, 2022 06:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sys/syscalls: make gettimeofday() implementation optional #17733

sys/syscalls: make gettimeofday() implementation optional #17733

fjmolinas commented Mar 2, 2022 •

edited

Loading

fjmolinas commented Mar 10, 2022

fjmolinas commented Mar 23, 2022

kfessel left a comment

fjmolinas commented Mar 24, 2022

kfessel left a comment •

edited

Loading

kfessel left a comment •

edited

Loading

benpicco commented Apr 27, 2022

sys/syscalls: make gettimeofday() implementation optional #17733

sys/syscalls: make gettimeofday() implementation optional #17733

Conversation

fjmolinas commented Mar 2, 2022 • edited Loading

Contribution description

Testing procedure

Issues/PRs references

fjmolinas commented Mar 10, 2022

fjmolinas commented Mar 23, 2022

kfessel left a comment

Choose a reason for hiding this comment

fjmolinas commented Mar 24, 2022

kfessel left a comment • edited Loading

Choose a reason for hiding this comment

kfessel left a comment • edited Loading

Choose a reason for hiding this comment

benpicco commented Apr 27, 2022

fjmolinas commented Mar 2, 2022 •

edited

Loading

kfessel left a comment •

edited

Loading

kfessel left a comment •

edited

Loading